(Phase 173)
· Sizecurve · LIVE — IN THE SHOPIFY APP STORE REVIEW QUEUE SINCE 13 SEPTEMBER · no commits recorded that day
PLAN AGAINST ACTUAL
Plan against actual
Each section of the plan against the sections of the actual, matched by heading. Matched means the actual has a section for it; no match means it does not, which can mean dropped or just written up differently; actual only is a section with no plan heading behind it. Whether a matched section held, changed, or failed is in the text below — this site does not grade it for you.
Planned
Why: after the release, the review goes back only when the boss has recorded a screencast of "how to configure the product and how those changes should reflect in the app UI" (issue 4.5.3). listing/SCREENCAST.md is the 13 September shot list for the full review, and it is out of date. Its Retakes note still says "The analysis caches for an hour. Append ?refresh=1". Nothing in it covers configuring a product. If the boss has to work out the take themselves, that's the slowest step between the yes and a resubmission.
What:
- A "Review 4.5.3 take" section in
listing/SCREENCAST.md: a timed shot list of about 2 minutes on sizecurve-dev that shows, in order: - a new product with no Size option appearing under Not shown; - the same product given a Size option with S/M/L, appearing under Every style; - a stock edit on an existing style showing on the next open; - Refresh; - restoring the demo store afterwards. Every on-screen label is checked against the source. - The stale Retakes note gets corrected.
- The reply text for "Show resolved state" goes in the file too, so the boss pastes it rather than composing it.
- Captioning: I caption the take the same way as the 13 September one (burn-subtitles.sh), once it's in the inbox.
Not doing: no writes to sizecurve-dev (the take's edits are the boss's, on their store), and no deploy.
Done when: the section is pushed, the boss has it in the conversation, and the plan and actual are pasted.
Actual
Found while writing the take: a read-only query of sizecurve-dev showed 28 active products, 12 of them sized. The other 16 (the Shopify sample snowboards, a gift card, ski wax and a candle) have no Size option. Phase 169 names the first 8 in catalogue order, so a product created during the take would have fallen into "and 9 more" and never been named. That's the reviewer's complaint again, one level down, and any real store with 8 or more unsized products hits it too.
Fixed, on main and deploy-fresh:
- The products query also reads
updatedAt. - Unsized products are sorted newest edit first before the 8-name cap, so the product just touched is named first.
- New test: 12 older boards plus "Just edited" → it comes first, then Board 11 and Board 10.
Tests: | Branch | unit | |---|---| | main | 530 pass, 0 fail | | deploy-fresh | 527 pass, 0 fail |
listing/SCREENCAST.md (both branches):
- The stale Retakes note is corrected. The analysis no longer caches for an hour; the app re-reads after an edit, and Refresh re-reads on demand.
- New "Review 4.5.3 take": 8 timed steps, about 2 minutes. Starting from Not shown at 16: 1. create Review Hoodie with no variants → Not shown 17, named first; 2. add Size S/M/L with stock → it moves to Every style, and Not shown drops back to 16; 3. change a Heavyweight Tee stock count → it shows on the next open; 4. press Refresh. An off-camera restore follows, so the demo stays as the testing instructions describe it.
- The "Show resolved state" reply text, ready to paste.
- My first draft said 17 unsized products. Recounting the query result gave 16, and the file is corrected.
Not checked: whether a new product in the admin defaults to Active. The step now says "Status: Active" either way.
Waiting on the boss: the release yes, then the take.